Skip to content

Conversation

@estringana
Copy link
Contributor

Description

Update json template accordingly to the minify version

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana marked this pull request as ready for review November 26, 2025 15:30
@estringana estringana requested a review from a team as a code owner November 26, 2025 15:30
@estringana estringana force-pushed the estringana/minify-json-blocking-error branch from 3cd7886 to 4a4d3e4 Compare November 26, 2025 15:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.69%. Comparing base (17189c6) to head (70314a1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3502      +/-   ##
==========================================
- Coverage   61.80%   61.69%   -0.11%     
==========================================
  Files         142      142              
  Lines       12923    12923              
  Branches     1695     1695              
==========================================
- Hits         7987     7973      -14     
- Misses       4183     4196      +13     
- Partials      753      754       +1     
Files with missing lines Coverage Δ
appsec/src/extension/request_abort.c 73.86% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17189c6...70314a1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2025-12-01 15:11:17

Comparing candidate commit 70314a1 in PR branch estringana/minify-json-blocking-error with baseline commit 17189c6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@estringana estringana force-pushed the estringana/minify-json-blocking-error branch 3 times, most recently from 6f96019 to ad6b3be Compare November 28, 2025 10:51
@estringana estringana force-pushed the estringana/minify-json-blocking-error branch from e1da67b to 70314a1 Compare December 1, 2025 14:34
@estringana estringana merged commit 2790073 into master Dec 2, 2025
2005 of 2008 checks passed
@estringana estringana deleted the estringana/minify-json-blocking-error branch December 2, 2025 09:53
@github-actions github-actions bot added this to the 1.15.0 milestone Dec 2, 2025
Leiyks pushed a commit that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants